Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.22.0] feat(time)!: epoch timestamps as standard #4507

Merged

Conversation

NDStrahilevitz
Copy link
Collaborator

Backport of #4252

commit: f25acd9 (main), cherry-pick
Instead of using a helper, and then using it in a specialized processor
function - use function currying to enable creating generic time argument
processors.

commit: c2d5e78 (main), cherry-pick
commit: 459a5c9 (main), cherry-pick
Remove all timeNormalizer object logic. Instead use simple normalization
functions and normalize all timestamps in events asap:
1. Context timestamp normalization moved to decode stage
2. Relevant timestamp arguments normalized in processing stage,
   registered to run first.

commit: 3233f0b (main), cherry-pick
@NDStrahilevitz
Copy link
Collaborator Author

unit tests pass, also checked manually if the sched_process events report epoch timestamps correctly in arguments.

@geyslan
Copy link
Member

geyslan commented Jan 16, 2025

Have you triggered it in the internal e2e tests?

Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If possible get e2e results before merging it.

@geyslan geyslan merged commit 0a3ee4d into aquasecurity:v0.22.0 Jan 16, 2025
4 checks passed
rscampos pushed a commit to rscampos/tracee that referenced this pull request Jan 17, 2025
commit: 0a3ee4 (v0.22.0), cherry-pick from the backported below
---

* chore: refactor time pkg

commit: f25acd9 (main), cherry-pick

* chore(pipeline): streamline time args normalization

Instead of using a helper, and then using it in a specialized processor
function - use function currying to enable creating generic time argument
processors.

commit: c2d5e78 (main), cherry-pick

* feat(output)!: remove relative-time

commit: 459a5c9 (main), cherry-pick

* feat(time): normalize all time to epoch

Remove all timeNormalizer object logic. Instead use simple normalization
functions and normalize all timestamps in events asap:
1. Context timestamp normalization moved to decode stage
2. Relevant timestamp arguments normalized in processing stage,
   registered to run first.

commit: 3233f0b (main), cherry-pick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants