-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v0.22.0] feat(time)!: epoch timestamps as standard #4507
Merged
geyslan
merged 4 commits into
aquasecurity:v0.22.0
from
NDStrahilevitz:backport_v0.22.0_time_cleanups
Jan 16, 2025
Merged
[v0.22.0] feat(time)!: epoch timestamps as standard #4507
geyslan
merged 4 commits into
aquasecurity:v0.22.0
from
NDStrahilevitz:backport_v0.22.0_time_cleanups
Jan 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: f25acd9 (main), cherry-pick
Instead of using a helper, and then using it in a specialized processor function - use function currying to enable creating generic time argument processors. commit: c2d5e78 (main), cherry-pick
commit: 459a5c9 (main), cherry-pick
Remove all timeNormalizer object logic. Instead use simple normalization functions and normalize all timestamps in events asap: 1. Context timestamp normalization moved to decode stage 2. Relevant timestamp arguments normalized in processing stage, registered to run first. commit: 3233f0b (main), cherry-pick
unit tests pass, also checked manually if the sched_process events report epoch timestamps correctly in arguments. |
Have you triggered it in the internal e2e tests? |
geyslan
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If possible get e2e results before merging it.
rscampos
pushed a commit
to rscampos/tracee
that referenced
this pull request
Jan 17, 2025
commit: 0a3ee4 (v0.22.0), cherry-pick from the backported below --- * chore: refactor time pkg commit: f25acd9 (main), cherry-pick * chore(pipeline): streamline time args normalization Instead of using a helper, and then using it in a specialized processor function - use function currying to enable creating generic time argument processors. commit: c2d5e78 (main), cherry-pick * feat(output)!: remove relative-time commit: 459a5c9 (main), cherry-pick * feat(time): normalize all time to epoch Remove all timeNormalizer object logic. Instead use simple normalization functions and normalize all timestamps in events asap: 1. Context timestamp normalization moved to decode stage 2. Relevant timestamp arguments normalized in processing stage, registered to run first. commit: 3233f0b (main), cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4252